Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add columnResizeDirection to support RTL column resizing #5192

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

samuelarbibe
Copy link
Contributor

@samuelarbibe samuelarbibe commented Dec 8, 2023

This PR adds support for RTL column resizing by adding a columnResizeDirection to column resize options, as discussed in #4331

@samuelarbibe samuelarbibe changed the title Add columnResizeDirection to support RTL column resizing Feature: Add columnResizeDirection to support RTL column resizing Dec 8, 2023
@@ -152,6 +152,14 @@ columnResizeMode?: 'onChange' | 'onEnd'

Determines when the columnSizing state is updated. `onChange` updates the state when the user is dragging the resize handle. `onEnd` updates the state when the user releases the resize handle.

### `columnResizeDirection`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt there a global setting to rtl, that we can depend on instead of allowing rtl specifically for column resizing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In another PR, I have introduced a global option rtl that could be used in other places.

But, this is the only feature that requires an explicit rtl setting. Other things can be sorted using CSS properties.

Therefore, I thought it would be more appropriate to make this a feature-specific option.

@KevinVandy KevinVandy merged commit cfdc3af into TanStack:main Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants